scrollToElement fails when element has position of 0 #127
Conversation
…t had a destX or destY of 0.
|
If you solved it using isNaN already. You can just close this issue. If you want to merge it into the master branch on your repository just go to your terminal and type in Thanks. |
|
Sorry for not managing to look at this pull request for so long! It sounds valid to me although I think I prefer the isNaN approach suggested by @nmiddleweek... Can you submit a pull request for that please? Also updating the last updated date in the comments at the top and generating a new minified version with yui compressor? (sorry the process is so manual - I haven't had any time to update this project to use grunt and make it easy to share the publishing process) |
|
Yup, sure, I'll create a pull request... Cheers guys. |
|
Fixed in #244 :) |
Found an issue where if you are trying to use scrollToElement with an element that is positioned at either top 0 or left 0, jscrollpane fails to scroll to that element.
Checking if a variable is undefined using a regular
'if(variable)'
is generally unsafe, especially when you're dealing with coordinates.
Since you potentially run into the issue of
variable = 0
if(variable)